Allow fork-PR checkout in pull_request_target workflows#1446
Open
JMJBILLINGS wants to merge 3 commits into
Open
Allow fork-PR checkout in pull_request_target workflows#1446JMJBILLINGS wants to merge 3 commits into
JMJBILLINGS wants to merge 3 commits into
Conversation
14 tasks
|
✅ JSON Filename Check Passed |
github-actions
Bot
added
the
Checklist of common problems not complete
|
✅ JSON Schema Validation Passed |
github-actions
Bot
added
PR description incomplete
Linter OK |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
pawel-kow
removed
the
automerge-possible
PR Description Check FailedThe PR description is missing required elements. Please update it according to the PR template. Details |
github-actions
Bot
added
the
automerge-possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1445.
All five pull_request_target workflows currently fail at the actions/checkout step for every fork PR — the Actions runner now refuses fork-PR checkout in pull_request_target workflows unless the checkout step sets
allow-unsafe-pr-checkout: true(see any recent fork PR's run annotations, e.g. #1444).This adds that one line to the checkout step in each of the five workflows. Risk note per https://gh.io/securely-using-pull_request_target: these workflows run base-repo tooling (dc-template-linter, check-jsonschema, .github/scripts) against changed root-level JSON files and do not execute contributed code, so the opt-in appears safe here — but please review.